Fix ORCA choosing wrong column type for CTAS with UNION ALL (#1431)#1645
Merged
yjhjstz merged 3 commits intoapache:mainfrom Apr 1, 2026
Merged
Fix ORCA choosing wrong column type for CTAS with UNION ALL (#1431)#1645yjhjstz merged 3 commits intoapache:mainfrom
yjhjstz merged 3 commits intoapache:mainfrom
Conversation
) When removing redundant Result nodes in the ORCA post-processing, push_down_expr_mutator replaces parent Var nodes with child expressions. It already propagates typmod for Const child expressions, but missed the case where the child expression is also a Var. This caused the correctly resolved common typmod (e.g. -1 for varchar without length) to be overwritten by the child's original typmod (e.g. varchar(1)), resulting in wrong column types in the created table.
Verify that ORCA produces the correct column type (character varying without length limit) when creating a table from UNION ALL of branches with different varchar lengths.
my-ship-it
approved these changes
Mar 30, 2026
Contributor
my-ship-it
left a comment
my-ship-it
left a comment
There was a problem hiding this comment.
LGTM. Nice catch and clean fix! 👍
reshke
approved these changes
Apr 1, 2026
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When removing redundant Result nodes in the ORCA post-processing, push_down_expr_mutator replaces parent Var nodes with child expressions. It already propagates typmod for Const child expressions, but missed the case where the child expression is also a Var. This caused the correctly resolved common typmod (e.g. -1 for varchar without length) to be overwritten by the child's original typmod (e.g. varchar(1)), resulting in wrong column types in the created table.
Fixes #1431
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions